Skip to content

fix: install uv inside active venv#1642

Merged
sre-ci-robot merged 1 commit into
mainfrom
tmp_knowhere_python_ver_fix
May 26, 2026
Merged

fix: install uv inside active venv#1642
sre-ci-robot merged 1 commit into
mainfrom
tmp_knowhere_python_ver_fix

Conversation

@jamesgao-jpg

@jamesgao-jpg jamesgao-jpg commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Fix scripts/install_deps.sh so uv is installed into the active virtualenv when VIRTUAL_ENV is set.
  • Keep the existing pip3 install --user uv path for non-virtualenv installs.
  • PR Update build scripts #1619 introduced the uv bootstrap path; this adjusts it for Jenkins jobs that already put a venv first in PATH.

Test Plan

  • Reproduced the old failure with a temporary virtualenv and no pre-existing uv on PATH.
  • Verified the virtualenv path installs and resolves uv from the temp venv.
  • Verified the non-virtualenv path still installs and resolves uv from the Python user bin.
  • bash -n scripts/install_deps.sh
  • git diff --check origin/main..origin/tmp_knowhere_python_ver_fix

@jamesgao-jpg
fix: install uv inside active venv
7bce50c 
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
@mergify

mergify Bot commented May 22, 2026

Copy link
Copy Markdown

@jamesgao-jpg 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@alexanderguzhva

alexanderguzhva commented May 26, 2026

Copy link
Copy Markdown
Collaborator

/lgtm

@alexanderguzhva

alexanderguzhva commented May 26, 2026

Copy link
Copy Markdown
Collaborator

issue: #1615
/kind improvement

@alexanderguzhva

alexanderguzhva commented May 26, 2026

Copy link
Copy Markdown
Collaborator

/approve

@sre-ci-robot

sre-ci-robot commented May 26, 2026

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, jamesgao-jpg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexanderguzhva

alexanderguzhva commented May 26, 2026

Copy link
Copy Markdown
Collaborator

/kind improvement

@sre-ci-robot sre-ci-robot merged commit fca2aaf into main May 26, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liliu-z liliu-z Awaiting requested review from liliu-z

@zhengbuqian zhengbuqian Awaiting requested review from zhengbuqian

Assignees

@alexanderguzhva alexanderguzhva

Labels

approved ci-passed dco-passed kind/improvement lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jamesgao-jpg @alexanderguzhva @sre-ci-robot